Open Graph card + contrast/a11y pass - #8
Merged
Conversation
…on, mobile nav affordance Adds --accent-text/--btn-fg tokens so accent-on-dark small text and button/selection text clear WCAG AA in all three themes, restores a visible focus ring in High Contrast (previously white-on-white), honors prefers-reduced-motion, hides the decorative "L E T'S TALK" line from screen readers, adds a skip link, and gives the mobile nav a fade+arrow affordance that clears on scroll or keyboard focus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Executes Plan 04 and Plan 08 from the 2026-08-31 site audit.
Plan 04 — Open Graph card, touch icon, theme color
scripts/render-og.mjsrenderspublic/og.png(1200×630, brand tokens) andpublic/apple-touch-icon.pngfrom a self-contained HTML template via Playwright — committed once, not built on every deploy.app/layout.tsx:og:image/twitter:card=summary_large_image/apple-touch-icon/theme-colormetadata.Plan 08 — Contrast, focus, motion, mobile nav
--accent-text/--btn-fgtokens so small accent-on-dark text and button/selection text clear WCAG AA 4.5:1 in all three themes (Gold/Oxblood/High Contrast) —__tests__/contrast.test.ts+lib/format/contrast.tsassert the measured pairs.:focus-visiblering in every theme, including High Contrast (previously white-on-white, invisible to keyboard users).prefers-reduced-motionsupport: pulse/hover-lift animations are suppressed (verified!important, since the base hover rules share specificity with the media-query override).L E T ' S T A L Ktext isaria-hidden; nav getsaria-label="Main"and a skip link to#projects.≤900px) gets a trailing-edge fade + arrow when more links are off-screen, clearing on scroll-to-end or keyboard focus (a masked/faded element would otherwise clip a tabbed-to link's focus ring).A code-reviewer pass on Plan 08 caught two CRITICAL and several HIGH/MEDIUM issues before this was pushed — all fixed and re-verified:
transform: nonewas losing a specificity tie to the base hover rules (no visible effect without!important).:focus-withinnow lifts the mask..btn-primary:hoverbackground in Oxblood dropped to 4.07:1 (below AA) — hover no longer lightens the fill..scrub-chip,.nf-count,.nf-stay:focus-visible) had been missed in the original accent→accent-text sweep.::selectionwas still 2.21:1 in the default Gold theme.#projects) is focusable (tabIndex={-1}) so Safari actually moves focus there.Test plan
npm test -- --run— 44/44 passing (incl. 6 new contrast-ratio tests)npx tsc --noEmit— cleannpm run lint— clean (2 pre-existing warnings/errors in untouched files)npm run build— OG/twitter/theme-color meta tags confirmed present inout/index.htmlnpx playwright test— 27/27 passing (horizontal-overflow and mobile-nav-reachable guards included)#c8102e(5.88:1) instead of white-on-#e63d52(4.07:1)🤖 Generated with Claude Code
https://claude.ai/code/session_01TUH1L7Q2FfGYa8dS7Lqvtz